@yuvalif ping?

@yuvalif This looks great, except for one thing. I don't understand why the nice explanation in the PR description is not in the commit message?

The commit message is:

 rgw/amqp: fix race condition in AMQP unit test

Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>

and the PR description is:

RGW/AMQP: fixing race condition in AMQP unit test

When connection object is deleted, all pending requests are nacked with "connection
closed" code. Tests were fixed so that this does not race with the actual messages
being acked or nacked. A specific tests was added to simulate this race condition.

Fixes: https://tracker.ceph.com/issues/42042
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>

The information included in the PR description actually belongs in the commit message... Otherwise, it is not accessible when browsing the git history.

@smithfarm thanks! thought it was in the commit message!

@yuvalif This looks great, except for one thing. I don't understand why the nice explanation in the PR description is not in the commit message?

The commit message is:

 rgw/amqp: fix race condition in AMQP unit test

Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>

and the PR description is:

RGW/AMQP: fixing race condition in AMQP unit test

When connection object is deleted, all pending requests are nacked with "connection
closed" code. Tests were fixed so that this does not race with the actual messages
being acked or nacked. A specific tests was added to simulate this race condition.

Fixes: https://tracker.ceph.com/issues/42042
Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>

The information included in the PR description actually belongs in the commit message... Otherwise, it is not accessible when browsing the git history.

@smithfarm so far I though that commit messages should be one liners, and the more detailed description belongs in the PR's description. will make sure, from now on, the info is in the commit.

Thanks, @yuvalif :-)