test/cls_rbd/test_cls_rbd: update TestClsRbd.sparsify#30258
Merged
tchaikov merged 1 commit intoceph:masterfrom Sep 10, 2019
Merged
test/cls_rbd/test_cls_rbd: update TestClsRbd.sparsify#30258tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
Member
|
oops, seems I slightly changed the output behavior of sparse_read. not sure if it is acceptable, |
xiexingguo
reviewed
Sep 9, 2019
Member
xiexingguo
left a comment
There was a problem hiding this comment.
I'd leave it to jason, since rbd is the main consumer of sparse_read
|
@tchaikov While this change is fine, the only issue is that I believe this test is run during upgrades, so if the OSD behaviour changes, older versions of the test will fail. |
Contributor
Author
|
@dillaman after a second thought, probably we could remove this test, if we are not relying on this behavior? |
|
@tchaikov Same upgrade problem. |
dillaman
reviewed
Sep 9, 2019
liewegas
approved these changes
Sep 9, 2019
Contributor
Author
|
changelog
|
dillaman
reviewed
Sep 9, 2019
after ceph#30061, extents returned by sparse read will always be an empty map as long as the extents to be read is empty or the extent(s) in it are empty, even of the objectstorage does not support sparse read. Fixes: https://tracker.ceph.com/issues/41721 Signed-off-by: Kefu Chai <kchai@redhat.com>
Contributor
Author
|
@dillaman fixed and repushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after #30061, extents returned by sparse read will always be
an empty map as long as the extents to be read is empty or the extent(s)
in it are empty, even of the objectstorage does not support sparse read.
Fixes: https://tracker.ceph.com/issues/41721
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docs