Skip to content

cmake: set empty RPATH for some test executables#29922

Merged
smithfarm merged 1 commit intoceph:masterfrom
smithfarm:wip-41524
Oct 2, 2019
Merged

cmake: set empty RPATH for some test executables#29922
smithfarm merged 1 commit intoceph:masterfrom
smithfarm:wip-41524

Conversation

@smithfarm
Copy link
Contributor

@smithfarm smithfarm commented Aug 27, 2019

Fixes: https://tracker.ceph.com/issues/41524
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm smithfarm requested review from kshtsk and tchaikov August 27, 2019 08:25
@smithfarm
Copy link
Contributor Author

smithfarm commented Aug 27, 2019

https://shaman.ceph.com/builds/ceph/wip-41524/da82cd4cc1035e02f6b5ccb7acc27b49f6e531ec/

@smithfarm
Copy link
Contributor Author

smithfarm commented Aug 27, 2019 

110/180 Test #104: check-generated.sh ......................***Failed   54.86 sec 
...
176/180 Test #105: readable.sh .............................***Failed  418.03 sec 
...

@tchaikov
Copy link
Contributor

tchaikov commented Aug 27, 2019

@smithfarm it's a known issue. and has been fixed.

retest this please.

@smithfarm
Copy link
Contributor Author

smithfarm commented Aug 27, 2019 

99% tests passed, 1 tests failed out of 180

Total Test time (real) = 3622.95 sec

The following tests FAILED:
	 56 - unittest_lockdep (Timeout)

@smithfarm
Copy link
Contributor Author

smithfarm commented Aug 27, 2019

jenkins test make check

@tchaikov
Copy link
Contributor

tchaikov commented Aug 30, 2019

@smithfarm i think #30028 could a better fix if it works. i am testing it.

@smithfarm
Copy link
Contributor Author

smithfarm commented Aug 30, 2019

@smithfarm i think #30028 could a better fix if it works. i am testing it.

I agree. Your fix looks much better :-)

@smithfarm smithfarm closed this Sep 6, 2019
@smithfarm smithfarm reopened this Oct 1, 2019
@smithfarm smithfarm requested a review from rjfd October 1, 2019 10:55
@smithfarm smithfarm mentioned this pull request Oct 1, 2019
Merged
3 tasks
@smithfarm
Copy link
Contributor Author

smithfarm commented Oct 1, 2019

@tchaikov Looks like we still need INSTALL_RPATH "" because I got FTBFS on openSUSE Tumbleweed even with #30028 applied.

Rebased this fix and testing it now.

@smithfarm smithfarm changed the title build/ops: set empty RPATH for some test executables cmake: set empty RPATH for some test executables Oct 1, 2019
@smithfarm
Copy link
Contributor Author

smithfarm commented Oct 1, 2019

https://shaman.ceph.com/builds/ceph/wip-41524/51a1c621718e65a7062af7dcf12949bdd79a26d1/

rjfd
rjfd approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@rjfd rjfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smithfarm
Copy link
Contributor Author

smithfarm commented Oct 1, 2019 •
edited
Loading

With this patch, the Tumbleweed build in OBS passes: https://build.opensuse.org/package/show/filesystems:ceph:master:upstream/ceph

Shaman build is green, too.

@smithfarm smithfarm merged commit 896ba76 into ceph:master Oct 2, 2019
@smithfarm smithfarm deleted the wip-41524 branch October 2, 2019 08:42
@smithfarm smithfarm removed the needs-qa label Oct 2, 2019
@smithfarm smithfarm mentioned this pull request Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

@kshtsk kshtsk Awaiting requested review from kshtsk

+1 more reviewer

@rjfd rjfd rjfd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build/ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smithfarm @tchaikov @rjfd