rgw: fix missing tenant prefix in bucket name during bucket link#29815
rgw: fix missing tenant prefix in bucket name during bucket link#29815cbodley merged 2 commits intoceph:masterfrom
Conversation
…ude 'tenant/' prefix. On account of recent rgw metadata refactoring changes, bucket link was broken. Bucket name was missing the tenant name prefix. Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
|
thanks @smanjara, it looks like this could fix https://tracker.ceph.com/issues/41306 too. i was hoping to get @mdw-at-linuxbox's feedback on the intended behavior though - i seem to remember a reason that the new tenant name had to be given as part of the --bucket-new-name=tenant/name |
ivancich
left a comment
There was a problem hiding this comment.
I agree with @cbodley that it would be useful to get @mdw-at-linuxbox's input. It seems there're are some subtle issues here.
| } | ||
| rgw_bucket old_bucket = bucket; | ||
| rgw_user user_id = op_state.get_user_id(); | ||
| bucket.tenant = user_id.tenant; |
There was a problem hiding this comment.
thanks! it looks like i messed this up in the metadata refactoring rebase here: #29118 (comment)
|
jenkins test this please |
|
Teuthology runs passed except for a few centos build failures : |
ivancich
left a comment
There was a problem hiding this comment.
Thanks for the explanations.
|
jenkins test docs |
|
@mdw-at-linuxbox ping? |
|
jenkins retest this please |
|
ok to merge once the checks are resolved |
|
unrelated failures from make check:
|
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
Seems like a regression. Tenant prefix was missing in bucket name while linking bucket to a tenanted user.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test docsjenkins render docs