luminous: osd/bluestore: Actually wait until completion in write_sync#29564
Merged
yuriw merged 1 commit intoceph:luminousfrom Oct 16, 2019
Merged
luminous: osd/bluestore: Actually wait until completion in write_sync#29564yuriw merged 1 commit intoceph:luminousfrom
yuriw merged 1 commit intoceph:luminousfrom
Conversation
This function is only used by RocksDB WAL writing so it must sync data. This fixes ceph#18338 and thus allows to actually set `bluefs_preextend_wal_files` to true, gaining +100% single-thread write iops in disk-bound (HDD or bad SSD) setups. To my knowledge it doesn't hurt performance in other cases. Test it yourself on any HDD with `fio -ioengine=rbd -direct=1 -bs=4k -iodepth=1`. Issue ceph#18338 is easily reproduced without this patch by issuing a `kill -9` to the OSD while doing `fio -ioengine=rbd -direct=1 -bs=4M -iodepth=16`. Fixes: https://tracker.ceph.com/issues/18338 https://tracker.ceph.com/issues/38559 Signed-off-by: Vitaliy Filippov <vitalif@yourcmc.ru> (cherry picked from commit c703cf9) Conflicts: - path: src/os/bluestore/KernelDevice.cc comment: luminous has a single variable "fd_buffered" where master has an array "fd_buffereds"
ifed01
approved these changes
Aug 27, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/41510
This function is only used by RocksDB WAL writing so it must sync data.
This fixes #18338 and thus allows to actually set
bluefs_preextend_wal_filesto true, gaining +100% single-thread write iops in disk-bound (HDD or bad SSD) setups.
To my knowledge it doesn't hurt performance in other cases.
Test it yourself on any HDD with
fio -ioengine=rbd -direct=1 -bs=4k -iodepth=1.Issue #18338 is easily reproduced without this patch by issuing a
kill -9to the OSDwhile doing
fio -ioengine=rbd -direct=1 -bs=4M -iodepth=16.Fixes: https://tracker.ceph.com/issues/18338 https://tracker.ceph.com/issues/38559
Signed-off-by: Vitaliy Filippov vitalif@yourcmc.ru
(cherry picked from commit c703cf9)
Conflicts:
comment: luminous has a single variable "fd_buffered" where master has an array "fd_buffereds"