Merged
Conversation
removes unused 'attrs' argument, and takes uid + display name instead of RGWUserInfo Signed-off-by: Casey Bodley <cbodley@redhat.com>
helper function to remove the user:buckets object. rgw_remove_uid_index() now omits the object version tracker argument to avoid reading the user info Signed-off-by: Casey Bodley <cbodley@redhat.com>
user rename creates a 'stub' user and links all buckets to that before modifying the existing user. once everything succeeds, the stub user is updated to match the existing user and all index objects are updated to point at it Signed-off-by: Casey Bodley <cbodley@redhat.com>
if a previous rename attempt fails to complete, it can be restarted with --yes-i-really-mean-it to overwrite the 'stub' user created previously Signed-off-by: Casey Bodley <cbodley@redhat.com>
this calls remove_old_indexes() to clean up the uid and buckets index objects, and also sets 'old_info = user_info' so that radosgw-admin dumps the json output of the renamed user instead of the old user Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
the rgw suite succeeded in http://pulpito.ceph.com/cbodley-2019-08-06_18:28:01-rgw-wip-rgw-user-rename-distro-basic-smithi before i added the final 'add rename_swift_keys for user rename' commit. a rerun of the rgw:singleton suite with that extra commit is pending in http://pulpito.ceph.com/cbodley-2019-08-07_18:49:03-rgw:singleton-wip-rgw-user-rename-distro-basic-smithi/ |
Contributor
Author
|
i rescheduled that last rgw:singleton run and it passed in http://pulpito.ceph.com/cbodley-2019-08-09_15:08:00-rgw:singleton-wip-rgw-user-rename-distro-basic-smithi/ |
mattbenjamin
approved these changes
Aug 9, 2019
Contributor
mattbenjamin
left a comment
There was a problem hiding this comment.
I think I follow and it looks ok
src/rgw/rgw_user.cc
Outdated
| // update the 'stub user' with all of the other fields and rewrite all of the | ||
| // associated index objects | ||
| RGWUserInfo user_info = old_user_info; | ||
| user_info.user_id = stub_user_info.user_id; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some cleanup and refactoring to make it closer to the new user interfaces in #29118. allows overwriting the --new-uid user when --yes-i-really-mean-it is given