nautilus: mgr/dashboard: Admin resource not honored#27868
Merged
yuriw merged 1 commit intoceph:nautilusfrom May 29, 2019
Merged
nautilus: mgr/dashboard: Admin resource not honored#27868yuriw merged 1 commit intoceph:nautilusfrom
yuriw merged 1 commit intoceph:nautilusfrom
Conversation
The current if-statement would always default to 'admin' as the admin resource regardless of what 'mgr/dashboard/RGW_API_ADMIN_RESOURCE' is set to. In some cases users change this setting in the RGW for various reasons. The dashboard currently does not support this and will cause the RGW management not to work. Fixes: http://tracker.ceph.com/issues/39338 Signed-off-by: Wido den Hollander <wido@42on.com> (cherry picked from commit 83b10ba)
Contributor
|
jenkins test make check |
votdev
approved these changes
May 6, 2019
Contributor
Contributor
|
jenkins re-test this please |
Contributor
|
"make check" failure is tracked by http://tracker.ceph.com/issues/39986 |
Contributor
|
jenkins re-test this please |
1 similar comment
Contributor
|
jenkins re-test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/39467