Skip to content

nautilus: mgr/dashboard: Admin resource not honored#27868

Merged
yuriw merged 1 commit intoceph:nautilusfrom
LenzGr:wip-39467-nautilus
May 29, 2019
Merged

nautilus: mgr/dashboard: Admin resource not honored#27868
yuriw merged 1 commit intoceph:nautilusfrom
LenzGr:wip-39467-nautilus

Conversation

@LenzGr
Copy link
Contributor

@LenzGr LenzGr commented Apr 29, 2019

The current if-statement would always default to 'admin' as the admin
resource regardless of what 'mgr/dashboard/RGW_API_ADMIN_RESOURCE' is set
to.

In some cases users change this setting in the RGW for various reasons.

The dashboard currently does not support this and will cause the RGW management
not to work.

Fixes: http://tracker.ceph.com/issues/39338

Signed-off-by: Wido den Hollander <wido@42on.com>
(cherry picked from commit 83b10ba)
@LenzGr LenzGr self-assigned this Apr 29, 2019
@LenzGr LenzGr added this to the nautilus milestone Apr 29, 2019
@LenzGr LenzGr requested review from p-se, votdev and wido April 29, 2019 16:17
@LenzGr LenzGr added dashboard and removed core labels Apr 29, 2019
Copy link
Member

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smithfarm
Copy link
Contributor

jenkins test make check

@LenzGr LenzGr added the nautilus-batch-1 nautilus point releases label May 4, 2019
@LenzGr LenzGr added the needs-qa label May 6, 2019
Copy link
Contributor

@p-se p-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuriw
Copy link
Contributor

yuriw commented May 16, 2019

@smithfarm smithfarm removed the nautilus-batch-1 nautilus point releases label May 20, 2019
@smithfarm
Copy link
Contributor

jenkins re-test this please

@smithfarm
Copy link
Contributor

"make check" failure is tracked by http://tracker.ceph.com/issues/39986

@smithfarm
Copy link
Contributor

jenkins re-test this please

1 similar comment
@smithfarm
Copy link
Contributor

jenkins re-test this please

@yuriw yuriw merged commit c02cdc2 into ceph:nautilus May 29, 2019
@LenzGr LenzGr deleted the wip-39467-nautilus branch June 21, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants