osd/PG: do not use approx_missing_objects pre-nautilus#27798
Merged
neha-ojha merged 1 commit intoceph:masterfrom Apr 26, 2019
Merged
osd/PG: do not use approx_missing_objects pre-nautilus#27798neha-ojha merged 1 commit intoceph:masterfrom
neha-ojha merged 1 commit intoceph:masterfrom
Conversation
We changed async recovery cost calculation in nautilus to also take into account approx_missing_objects in ab241bf This commit depends on ceph#23663, hence wasn't backported to mimic. Mimic only uses the difference in length of logs as the cost. Due to this, the same OSD might have different costs in a mixed mimic and nautilus(or above) cluster. This can lead to choose_acting() cycling between OSDs, when trying to select the acting set and async_recovery_targets. Fixes: https://tracker.ceph.com/issues/39441 Signed-off-by: Neha Ojha <nojha@redhat.com>
Member
Author
|
rados run looks fine http://pulpito.ceph.com/nojha-2019-04-25_05:43:35-rados-wip-39441-distro-basic-smithi/ testing the reproducer for https://tracker.ceph.com/issues/39441 |
xiexingguo
approved these changes
Apr 26, 2019
Member
xiexingguo
left a comment
There was a problem hiding this comment.
Thanks for catching this, Neha!
Member
Author
|
No related failures in 20 runs of the reproducer: http://pulpito.ceph.com/nojha-2019-04-25_05:40:23-rados:upgrade:mimic-x-singleton-wip-39441-distro-basic-smithi/ Dead jobs: |
jdurgin
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We changed async recovery cost calculation in nautilus to also take
into account approx_missing_objects in ab241bf
This commit depends on #23663, hence
wasn't backported to mimic.
Mimic only uses the difference in length of logs as the cost. Due to this,
the same OSD might have different costs in a mixed mimic and nautilus(or above)
cluster. This can lead to choose_acting() cycling between OSDs, when trying
to select the acting set and async_recovery_targets.
Fixes: https://tracker.ceph.com/issues/39441
Signed-off-by: Neha Ojha nojha@redhat.com