rgw: switch AES_256_{CBC, ECB_encrypt} from NSS to OpenSSL#27659
rgw: switch AES_256_{CBC, ECB_encrypt} from NSS to OpenSSL#27659rzarzynski wants to merge 4 commits intoceph:masterfrom
Conversation
mattbenjamin
left a comment
There was a problem hiding this comment.
defer to marcus, but looks sane
| #ifdef USE_OPENSSL | ||
| # include <openssl/evp.h> | ||
| #endif // USE_OPENSSL | ||
|
|
There was a problem hiding this comment.
Fixed by keeping the #else clause we had for NSS.
| const unsigned char* const iv, | ||
| const unsigned char* const key, | ||
| const bool encrypt) | ||
| { |
There was a problem hiding this comment.
is line continuation needed here?
There was a problem hiding this comment.
oh, it's not new anyway, sorry
There was a problem hiding this comment.
Do you mean new line before the bracket? I tried to be consistent with closest neighborhood but I stay open to reformatting entire file.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
448e50f to
6111ce0
Compare
|
looks good to me, and passing tests. ping @mdw-at-linuxbox |
|
It's worth to mention that #27834 is built on top of these patches. In contrast to the broader PR, changes here are focused solely on RGW. This can help with reviewing both of them, I hope. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Closing as #27834 has been merged! |
After this patchset gets in, the last NSS user will be the legacy PKI token support of Keystone.
UPDATE: PKI/PKIz tokens have been dropped in 2016 from Keystone. See openstack/keystone@8a66ef6.