ceph-volume: Fix TypeError: join() takes exactly one argument (2 given)#25469
Conversation
|
Fixing a regression introduced in #25425 |
|
This needs to have unit tests associated with this function. Otherwise regressions like the one this PR is fixing can keep going undetected. Please include the unit tests needed to cover all cases in this function. |
|
This regression was found by #25236 which will add Teuthology testing to the orchestrator (which will invoke c-v). So, #25236 can already be seen as the integration test code for this PR. Right now, I don't have time to add additional unit tests for this function. If you want to, I can look into adding unit tests for this PR tomorrow. |
|
Sure, I don't mind other functional tests. But for sure we don't want to pursue more changes without having tests that verify the patch. |
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
dd0b548 to
38f289b
Compare
Added a test for |
|
jenkins test ceph-volume tox |
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
Fixes: http://tracker.ceph.com/issues/37595