ceph-volume: test with multiple NVME drives#25354
Merged
alfredodeza merged 14 commits intomasterfrom Dec 10, 2018
Merged
Conversation
Contributor
Author
|
jenkins test ceph-volume batch all |
Contributor
Author
|
jenkins test ceph-volume lvm all |
Contributor
Author
|
jenkins test ceph-volume tox |
8f9fc49 to
1df053c
Compare
Contributor
Author
|
jenkins test ceph-volume tox |
Contributor
Author
|
jenkins test ceph-volume batch all |
Contributor
Author
|
jenkins test ceph-volume lvm all |
alfredodeza
approved these changes
Nov 30, 2018
Contributor
Author
|
jenkins test ceph-volume batch all |
Contributor
Author
|
jenkins test ceph-volume lvm all |
1 similar comment
Contributor
|
jenkins test ceph-volume lvm all |
1df053c to
6dfca9b
Compare
Contributor
Author
|
jenkins test ceph-volume batch all |
6dfca9b to
1ae4c42
Compare
Contributor
Author
|
jenkins test ceph-volume batch all |
Signed-off-by: Andrew Schoen <aschoen@redhat.com> Resolves: bz#1650306
In the batch command use extents instead of size when creating lvs. This gives a more precise size and avoids rounding errors. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This is to enable testing of the --block-db-size flag Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This allows us to create larger lvs than the default of 4m and is easier to reason about when sizing the lvs as everythign is reported as GBs. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
The self.use_large_block_db property was never getting set because the block in compute was never called as block_db_size was reset in validate if it was 0. We needed to set self.use_large_block_db in validate instead of compute. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
… size We know with a mixed type scenario the device used for data will be used at 100% capacity. This means we do not need to be explict when asking for the size of the data lvs, which avoids rounding errors with very small device sizes. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This will give us the size lvm should report because it takes into account the 1GB physical extent size we set. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
We should show the user what the size of the device will be after lvm creates a pv out of it. This way there isn't a discrepency between the sizes that are reported to the user and what is actually created. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This will validate the devices on the size that lvm will allow to be used, not the raw physical size of the device. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This increases the size of the HDD devices that virtualbox creates so that they can pass the validator for filestore single type tests locally. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
1ae4c42 to
4074cb7
Compare
This is so tests can continue to set sys_api['size'] and the code can retrieve that as Device.lvm_size Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Contributor
Author
|
jenkins test ceph-volume batch all |
Contributor
Author
|
jenkins test ceph-volume tox |
Contributor
Author
|
jenkins test ceph-volume batch centos7-bluestore-mixed_type |
Contributor
Author
|
jenkins test ceph-volume lvm all |
Contributor
|
@andrewschoen have you noticed https://tracker.ceph.com/issues/37590 about this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
batchmixed-type tests will now test with two nvme drives. This also changes our PE size to 1G for all vgs we create. This makes sizing vgs easier as everything reports as GBs and allows for creation of larger sized lvs than the default value of 1m for PE size.Fixes: http://tracker.ceph.com/issues/37409