mimic ceph-volume add device_id to inventory listing#25349
Merged
alfredodeza merged 2 commits intoceph:mimicfrom Dec 4, 2018
alfredodeza:mimic-c-v-inventory-add-device_id
Merged
mimic ceph-volume add device_id to inventory listing#25349alfredodeza merged 2 commits intoceph:mimicfrom alfredodeza:mimic-c-v-inventory-add-device_id
alfredodeza merged 2 commits intoceph:mimicfrom
alfredodeza:mimic-c-v-inventory-add-device_id
Conversation
added 2 commits
November 30, 2018 14:01
jan--f
approved these changes
Dec 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the device_id implementation from using
ID_SERIALtoID_MODEL + _ + ID_SERIAL_SHORT(1) and adds an equivalent python implementation to ceph-volume (2).The reasoning is that the new implementation seem more reliable.
ID_SERIALoften contains the model and serial, but sometimes only the serial.The python implementation is not equivalent yet for the FreeBSD case. In C++ this uses sysfs and
ioctlwith a (Free?)BSD specific constant. I'm not sure yet of the same call can be made with python'sioctlimplementation. If so this should also be a RFC if we should move this to python/ceph-volume and call it from C++ to avoid the duplicate implementation.Fixes: https://tracker.ceph.com/issues/37083
Backport of: #25201