log/tests: Added test for using log in multithread env#23982
Closed
aclamk wants to merge 1 commit intoceph:masterfrom
Closed
log/tests: Added test for using log in multithread env#23982aclamk wants to merge 1 commit intoceph:masterfrom
aclamk wants to merge 1 commit intoceph:masterfrom
Conversation
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
batrick
reviewed
Sep 10, 2018
| buffers[i] = std::string(buf_size, (char)rand()); | ||
|
|
||
| for (size_t i = 0; i < 200000; i++) { | ||
| buffers[rand() % buf_cnt] = buffers[rand() % buf_cnt]; |
Member
There was a problem hiding this comment.
What is this really measuring? I'm not really seeing a trend from https://gist.github.com/aclamk/aeb0faf22c271fddabc81c5efe9fa1e5
Contributor
Author
There was a problem hiding this comment.
@batrick The test I made was faulty.
The intention was to measure impact on page tables and tls walks.
The actual result was totally garbled because rand() does protect its context with mutex. This caused all wierd results.
Please ignore this result for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to judge performance of logging in case of multithread environments.
Created to evaluate performance boost and best ConcreteEntry size in #23721.
Signed-off-by: Adam Kupczyk akupczyk@redhat.com