osd/PG: restrict async_recovery_targets to up osds#22664
Merged
jdurgin merged 1 commit intoceph:masterfrom Jun 21, 2018
Merged
Conversation
Member
Author
|
No failures in 50 runs of that particular test which failed earlier: No related failures in the rados suite run: |
liewegas
reviewed
Jun 21, 2018
| // do not include strays | ||
| if (stray_set.find(shard_i) != stray_set.end()) | ||
| continue; | ||
| if (!is_up(shard_i)) |
Member
There was a problem hiding this comment.
maybe add a comment explaining why !up shards are excluded?
When an osd that is part of the acting set and not the up set, gets chosen as an async_recovery_target, it gets removed from the acting set. Since this osd is no longer in the up or acting set, it is classified as a stray in the next peering cycle. This results in choose_acting() looping between two proposed acting sets. To avoid this, we will only choose up osds as async_recovery_targets. Signed-off-by: Neha Ojha <nojha@redhat.com>
f19af6a to
7f1b6ad
Compare
jdurgin
approved these changes
Jun 21, 2018
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an osd that is part of the acting set and not the up set, gets chosen
as an async_recovery_target, it gets removed from the acting set. Since this
osd is no longer in the up or acting set, it is classified as a stray in
the next peering cycle. This results in choose_acting() looping between two
proposed acting sets.
To avoid this, we will only choose up osds as async_recovery_targets.
Fixes: https://tracker.ceph.com/issues/24487
Signed-off-by: Neha Ojha nojha@redhat.com