osd, librados: add unset-manifest op#21999
Merged
tchaikov merged 4 commits intoceph:masterfrom Jun 5, 2018
Merged
Conversation
Signed-off-by: Myoungwon Oh <omwmw@sk.com>
fee3adb to
6fb5afd
Compare
Member
Author
|
@liewegas We need to discuss the remaining works and plan for dedup tier.
So, I would like to start remaining works in the above order. |
liewegas
approved these changes
Jun 1, 2018
Member
|
This plan sounds right! Let's sketch out the abstraction/interfaces for the hashing and chunking.. |
tchaikov
reviewed
Jun 2, 2018
src/test/librados/tier.cc
Outdated
| cache_ioctx.exec("bar", "refcount", "chunk_read", in, out); | ||
| cls_chunk_refcount_read_ret read_ret; | ||
| try { | ||
| bufferlist::iterator iter = out.begin(); |
Contributor
There was a problem hiding this comment.
because of the recent bufferlist::const_iterator change, please use out.cbegin()
Contributor
There was a problem hiding this comment.
Contributor
|
retest this please. |
Signed-off-by: Myoungwon Oh <omwmw@sk.com>
Signed-off-by: Myoungwon Oh <omwmw@sk.com>
Signed-off-by: Myoungwon Oh <omwmw@sk.com>
6fb5afd to
3133392
Compare
Member
Author
|
@tchaikov Fixed. Can you take a look? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new rados op (unset-manifest).
Please refer to #19935.
Signed-off-by: Myoungwon Oh omwmw@sk.com