qa/suites: set osd_pg_log_dups_tracked in cfuse_workunit_suites_fsync.yaml#21909
Merged
jdurgin merged 1 commit intoceph:masterfrom May 9, 2018
Merged
qa/suites: set osd_pg_log_dups_tracked in cfuse_workunit_suites_fsync.yaml#21909jdurgin merged 1 commit intoceph:masterfrom
jdurgin merged 1 commit intoceph:masterfrom
Conversation
….yaml Signed-off-by: Neha Ojha <nojha@redhat.com>
Member
Author
|
All 100 runs of the same test passed with this fix. http://pulpito.ceph.com/nojha-2018-05-08_22:23:43-powercycle-luminous-distro-basic-smithi/ |
jdurgin
approved these changes
May 9, 2018
Member
|
I'm trying to better understand the bug and fix. I'm not getting how this is a duplicate op issue. Shouldn't replies from the OSD be ordered by the |
Member
Author
|
When we do not track enough dup ops, the ops which are actually dup ops end up being treated like new ops. In the asserts that this bug has been causing, we've seen the |
Contributor
|
@theanalyst @smithfarm we need mimic backport |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase
osd_pg_log_dups_trackedfor this test, so that we keep track of dup ops and don't end up treating dup ops as new ops.Fixes: https://tracker.ceph.com/issues/23827
Signed-off-by: Neha Ojha nojha@redhat.com