debian: let ceph-mgr depend on python-influxdb#21594
Closed
tchaikov wants to merge 2 commits intoceph:masterfrom
Closed
debian: let ceph-mgr depend on python-influxdb#21594tchaikov wants to merge 2 commits intoceph:masterfrom
tchaikov wants to merge 2 commits intoceph:masterfrom
Conversation
Contributor
Author
This was referenced Apr 23, 2018
Contributor
|
I don't mind adding the dependency for platforms where installing the influx module is easy, but the test is meant to pass without the dependency (module selftest shouldn't have dependencies). Since we're now rejecting "enable" for can_run=false modules, we should update the test to pass --force to enable so that it can run selftest even if dependencies are missing. |
the influx plugin requires influxdb python module to function, but influxdb mgr plugin is optional for users who don't use influxdb. so it's marked "Suggests" at this moment before we use a more flexible packaging scheme. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
09b890c to
c3ceb85
Compare
Contributor
Author
|
@jcsp updated and repushed. |
jcsp
approved these changes
Apr 23, 2018
Contributor
|
retest this please (jenkins) Something went wrong in a pip download |
liewegas
approved these changes
Apr 23, 2018
Member
|
btw still see an error after this, 2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner:======================================================================
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner:ERROR: test_influx (tasks.mgr.test_module_selftest.TestModuleSelftest)
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-sage3-testing-2018-04-23-0831/qa/tasks/mgr/test_module_selftest.py", line 43, in test_influx
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner: self._selftest_plugin("influx")
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-sage3-testing-2018-04-23-0831/qa/tasks/mgr/test_module_selftest.py", line 29, in _selftest_plugin
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner: self.mgr_cluster.mon_manager.raw_cluster_cmd(module_name, "self-test")
2018-04-23T18:14:50.070 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-sage3-testing-2018-04-23-0831/qa/tasks/ceph_manager.py", line 1134, in raw_cluster_cmd
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: stdout=StringIO(),
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 193, in run
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 423, in run
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: r.wait()
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 155, in wait
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: self._raise_for_status()
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 177, in _raise_for_status
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner: node=self.hostname, label=self.label
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner:CommandFailedError: Command failed on smithi149 with status 124: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph influx self-test'
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner:
2018-04-23T18:14:50.071 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:Ran 1 test in 147.604s
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:FAILED (errors=1)
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:======================================================================
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:ERROR: test_influx (tasks.mgr.test_module_selftest.TestModuleSelftest)
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-sage3-testing-2018-04-23-0831/qa/tasks/mgr/test_module_selftest.py", line 43, in test_influx
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner: self._selftest_plugin("influx")
2018-04-23T18:14:50.072 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-sage3-testing-2018-04-23-0831/qa/tasks/mgr/test_module_selftest.py", line 29, in _selftest_plugin
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: self.mgr_cluster.mon_manager.raw_cluster_cmd(module_name, "self-test")
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-sage3-testing-2018-04-23-0831/qa/tasks/ceph_manager.py", line 1134, in raw_cluster_cmd
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: stdout=StringIO(),
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 193, in run
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 423, in run
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: r.wait()
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 155, in wait
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: self._raise_for_status()
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 177, in _raise_for_status
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner: node=self.hostname, label=self.label
2018-04-23T18:14:50.073 INFO:tasks.cephfs_test_runner:CommandFailedError: Command failed on smithi149 with status 124: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph influx self-test'
/a/sage-2018-04-23_15:07:57-rados-wip-sage3-testing-2018-04-23-0831-distro-basic-smithi/2430983 expected? |
Contributor
|
This isn't working because PyModuleRegistry skips starting modules when can_run=false. I'll open a PR that tweaks the behaviour to get us back the ability to run the selftest bits. |
Member
|
Should this get merged as a partial fix, or wait? |
Contributor
|
See #21607 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com