common/strtol: fix strict_strtoll() so it accepts hex starting with 0x#21521
Merged
tchaikov merged 1 commit intoceph:masterfrom Apr 21, 2018
Merged
common/strtol: fix strict_strtoll() so it accepts hex starting with 0x#21521tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
ukernel
reviewed
Apr 19, 2018
src/common/strtol.cc
Outdated
| *err = errStr.str(); | ||
| if (endptr == str.data() || endptr != str.data() + str.size()) { | ||
| *err = (std::string("Expected option value to be integer, got '") + | ||
| std::string(str.data(), str.size()) + "'"); |
Contributor
There was a problem hiding this comment.
std::string(str) also works
e763ac3 to
8359d16
Compare
- simplify the error handling of strtoll(). - only instantiate ostringstream when handling errors. Signed-off-by: Kefu Chai <kchai@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com