qa: disable -Werror when compiling env_librados_test#21433
Merged
tchaikov merged 1 commit intoceph:masterfrom Apr 16, 2018
Merged
qa: disable -Werror when compiling env_librados_test#21433tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
to silence warnings like
utilities/env_librados.cc:175:33: warning: unused parameter ‘offset’ [-Wunused-parameter]
Status InvalidateCache(size_t offset, size_t length) {
^~~~~~
Signed-off-by: Kefu Chai <kchai@redhat.com>
Contributor
Author
This was referenced Apr 15, 2018
Contributor
Author
liewegas
approved these changes
Apr 16, 2018
Member
liewegas
left a comment
There was a problem hiding this comment.
Seems okay. We could also do (void)paramname; statements to explicitly ignore args, right?
Contributor
Author
|
yeah, that's another option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to silence warnings like
utilities/env_librados.cc:175:33: warning: unused parameter ‘offset’ [-Wunused-parameter]
Status InvalidateCache(size_t offset, size_t length) {
^~~~~~
Signed-off-by: Kefu Chai kchai@redhat.com