Skip to content

cmake: disable -fvar-tracking-assignments for config.cc#16695

Merged
gregsfortytwo merged 1 commit intoceph:masterfrom
tchaikov:wip-cmake-disable-vta
Jul 31, 2017
Merged

cmake: disable -fvar-tracking-assignments for config.cc#16695
gregsfortytwo merged 1 commit intoceph:masterfrom
tchaikov:wip-cmake-disable-vta

Conversation

@tchaikov
Copy link
Contributor

there are too many variables involved in config.cc, but
-fvar-tracking-assignments is enabled by default, when the compiler
finds that the number of variables exceeds the limit
"max-vartrack-size", it gives up, and tries again disabling this
option.

this change avoids the recompilation of config.cc and also
silences the warning of

src/common/config.cc:77:1: note: variable tracking size limit exceeded
with -fvar-tracking-assignments, retrying without
md_config_t::md_config_t(bool is_daemon)
^

Signed-off-by: Kefu Chai kchai@redhat.com

there are too many variables involved in config.cc, but
-fvar-tracking-assignments is enabled by default, when the compiler
finds that the number of variables exceeds the limit
"max-vartrack-size", it gives up, and tries again disabling this
option.

this change avoids the recompilation of config.cc and also
silences the warning of

src/common/config.cc:77:1: note: variable tracking size limit exceeded
with -fvar-tracking-assignments, retrying without
 md_config_t::md_config_t(bool is_daemon)
 ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

see https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos7,DIST=centos7,MACHINE_SIZE=huge/5273//consoleFull

build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/12.1.1-869-g08a6f41/rpm/el7/BUILD/ceph-12.1.1-869-g08a6f41/src/common/options.cc: In function 'void _Z41__static_initialization_and_destruction_0ii.constprop.1008()':
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/12.1.1-869-g08a6f41/rpm/el7/BUILD/ceph-12.1.1-869-g08a6f41/src/common/options.cc:5673:57: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 const std::vector<Option> ceph_options = build_options();
                                                         ^

Copy link
Member

@gregsfortytwo gregsfortytwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gregsfortytwo gregsfortytwo merged commit b16b973 into ceph:master Jul 31, 2017
@tchaikov tchaikov deleted the wip-cmake-disable-vta branch August 1, 2017 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants