mon,osd: add require_min_compat_client setting to enforce and clarify client compatibility#14959
Merged
liewegas merged 15 commits intoceph:masterfrom May 9, 2017
Merged
mon,osd: add require_min_compat_client setting to enforce and clarify client compatibility#14959liewegas merged 15 commits intoceph:masterfrom
liewegas merged 15 commits intoceph:masterfrom
Conversation
|
Having a feature bit makes things easier for http://tracker.ceph.com/issues/19836, great ! |
|
Should we add a CrushWrapper method encode_with_choose_args_pre_luminuous_if_possible to be called instead of encode if the client is pre-luminous ? Or should that be done outside of CrushWrapper ? |
Member
Author
|
I think you can just look at the features argumetn in
CrushWrapper::encode. If has_chooseargs() and
!HAVE_FEATURE(CRUSH_CHOOSEARGS) then do the compat encoding.
|
|
Ok. |
|
The UNIX domain socket path /home/jenkins-build/build/workspace/ceph-pull-requests/build/src/test/td/t-7202/out/client.xx-profile-ro.15033.asok is too long jenkins test this please |
1 similar comment
|
The UNIX domain socket path /home/jenkins-build/build/workspace/ceph-pull-requests/build/src/test/td/t-7202/out/client.xx-profile-ro.15033.asok is too long jenkins test this please |
|
#15002 has the modified CrushWrapper::encode |
Calculate the oldest client we allow to connect. Provide both a release name (e.g., firefly) and a version string (e.g., "0.80"). Signed-off-by: Sage Weil <sage@redhat.com>
This is a persistent record of the compatibility for old clients that we will enforce. Once set, the mon will eventually prevent newer features of the OSDMap or CRUSH maps from being used if they violate this requirement. Signed-off-by: Sage Weil <sage@redhat.com>
…lusters Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Fill in this field once require_luminous is set. Signed-off-by: Sage Weil <sage@redhat.com>
…compat_client If require_min_compat_client is set (we've finished luminous upgrade), use that to enforce primary_temp and primary_affinity settings. Otherwise, use the legacy config option. Drop the assert in update_from_paxos. After luminous we can remove the config options entirely. Signed-off-by: Sage Weil <sage@redhat.com>
…ient instead Signed-off-by: Sage Weil <sage@redhat.com>
…compat_client Signed-off-by: Sage Weil <sage@redhat.com>
Missed this with the remap -> upmap rename a few weeks back. Signed-off-by: Sage Weil <sage@redhat.com>
We'll use this for feature bit compat checks with clients and osds. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
For cases where we are selecting crush tunables beyond the default min of hammer. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Member
Author
|
squashed commits and fixed cli test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.