qa/tasks/admin_socket: subst in repo name#12508
Merged
liewegas merged 1 commit intoceph:masterfrom Dec 15, 2016
Merged
Conversation
dillaman
reviewed
Dec 15, 2016
| test_path = None | ||
| if 'test' in config: | ||
| # hack: the git_url is always ceph-ci or ceph | ||
| git_url = teuth_config.get_ceph_git_url() |
There was a problem hiding this comment.
Could just pass the full url (minus the file) via a new variable (e.g. repo_url_base = git_url + "?p=" + repo_name + ";a=blob_plan;hb=" + branch + ";f=") since lots of rbd workunits need fixes like this as well.
3c05e7a to
1cc6f42
Compare
Member
Author
|
the workunit fix should be different, i think.. it already clones the git
repo on the front end. we just need to remove the rename (and probably
add --depth 1 to speed up the clone).
|
It is either ceph.git or ceph-ci.git. Signed-off-by: Sage Weil <sage@redhat.com>
1cc6f42 to
bcbe45d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is either ceph.git or ceph-ci.git.
Signed-off-by: Sage Weil sage@redhat.com