Merged
Conversation
e98a09a to
681c368
Compare
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Matches rm(). Signed-off-by: Sage Weil <sage@redhat.com>
3dde4df to
3dcadef
Compare
src/os/bluestore/BlueStore.h
Outdated
|
|
||
| ExtentMap(Onode *o); | ||
| ~ExtentMap() { | ||
| auto p = extent_map.begin(); |
Contributor
There was a problem hiding this comment.
you may use something like that instead:
extent_map.clear_and_dispose( [](Extent* e) {delete e;});
Contributor
|
LGTM |
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
We need to remove items from the cache LRUs in their destructors, and it is very awkward to ensure that all releasing paths either hold the cache lock or have already cleared the cache items out. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
3dcadef to
cdde7b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.