Skip to content

feat(config): remove global timeout, make per-request#6

Merged
btschwartz12 merged 3 commits intomainfrom
bschwartz/remove-global-timeout
Oct 17, 2025
Merged

feat(config): remove global timeout, make per-request#6
btschwartz12 merged 3 commits intomainfrom
bschwartz/remove-global-timeout

Conversation

@btschwartz12
Copy link
Contributor

This PR does a few things:

  • Removes the global command timeout. This has only caused problems to users so far, and offers no benefit. Users shouldn't be required to manually fiddle with the timeout value to figure out what is sufficient for a long-running command they want to run. This PR switches to a less-restrictive approach, by allowing users to opt-in to a per-request timeout.
  • Refactors the config file and relevant code. There is now two new config structs, timeouts and spinner. You can see what they look like by pulling and compiling off this branch and running config print
  • Introduces a new "stopwatch" component to the spinner. Users can see how long their operation is taking, and the stopwatch only appears after a configurable amount of time

@btschwartz12 btschwartz12 force-pushed the bschwartz/remove-global-timeout branch from 60ddb3c to 95e7b47 Compare October 17, 2025 14:22
@btschwartz12 btschwartz12 force-pushed the bschwartz/remove-global-timeout branch from 95e7b47 to 9feca84 Compare October 17, 2025 14:23
@censys censys deleted a comment from github-actions bot Oct 17, 2025
@censys censys deleted a comment from github-actions bot Oct 17, 2025
@btschwartz12 btschwartz12 force-pushed the bschwartz/remove-global-timeout branch from f009b51 to 0693627 Compare October 17, 2025 19:18
@censys censys deleted a comment from github-actions bot Oct 17, 2025
@github-actions
Copy link

📚 Documentation Reminder

This PR modifies command implementation files but doesn't update the corresponding documentation:

Action Required:

  • If your changes affect user-facing behavior (flags, output, functionality), please update the documentation files listed above.
  • If your changes are internal only (refactoring, bug fixes with no behavior change), you can safely ignore this message.

This is an automated check to help keep our documentation in sync with code changes.

@btschwartz12 btschwartz12 merged commit b087931 into main Oct 17, 2025
6 checks passed
@btschwartz12 btschwartz12 deleted the bschwartz/remove-global-timeout branch October 17, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants