This repository was archived by the owner on Nov 7, 2022. It is now read-only.
Fixed Jaeger GRPC exporter#622
Merged
owais merged 1 commit intocensus-instrumentation:masterfrom Sep 5, 2019
Merged
Conversation
b275351 to
1148791
Compare
songy23
approved these changes
Sep 5, 2019
Contributor
Author
|
Travis build is failing for an unrelated reason. Looks like it can't pull in some dependencies. I tried building locally even after wiping all of my Go modules cache and it worked without any issues. CI error: |
The exporter was essentially crashing itself unconditionally
1148791 to
14f4185
Compare
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 69.35% 69.34% -0.02%
==========================================
Files 93 93
Lines 6157 6158 +1
==========================================
Hits 4270 4270
- Misses 1660 1661 +1
Partials 227 227
Continue to review full report at Codecov.
|
Contributor
Author
|
The repo was moved to github. Adding a replace directive fixed the build. https://github.com/census-instrumentation/opencensus-service/pull/622/files#diff-37aff102a57d3d7b797f152915a6dc16R63 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exporter was essentially crashing itself unconditionally