This repository was archived by the owner on Nov 7, 2022. It is now read-only.
Add metrics service gRPC gateway. Upgrade deps.#608
Merged
songy23 merged 3 commits intocensus-instrumentation:masterfrom Jul 18, 2019
Merged
Add metrics service gRPC gateway. Upgrade deps.#608songy23 merged 3 commits intocensus-instrumentation:masterfrom
songy23 merged 3 commits intocensus-instrumentation:masterfrom
Conversation
odeke-em
approved these changes
Jul 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 68.45% 68.61% +0.15%
==========================================
Files 91 91
Lines 5935 5939 +4
==========================================
+ Hits 4063 4075 +12
+ Misses 1660 1650 -10
- Partials 212 214 +2
Continue to review full report at Codecov.
|
pjanotti
approved these changes
Jul 18, 2019
go.mod
Outdated
| contrib.go.opencensus.io/exporter/aws v0.0.0-20181029163544-2befc13012d0 | ||
| contrib.go.opencensus.io/exporter/jaeger v0.1.1-0.20190430175949-e8b55949d948 | ||
| contrib.go.opencensus.io/exporter/ocagent v0.5.0 | ||
| contrib.go.opencensus.io/exporter/ocagent v0.5.1-0.20190621222907-f9129169651c // TODO: pin a released version |
There was a problem hiding this comment.
just to confirm: there aren't changes to ocagent and stackdriver this is just to match the same proto version, correct?
Contributor
Author
There was a problem hiding this comment.
There're also some small bug fixes in both of them. You reminded me to upgrade the proto versions :) Just sent census-ecosystem/opencensus-go-exporter-ocagent#74.
Contributor
Author
|
Fixed dependency version and added a simple test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #607