This repository was archived by the owner on Nov 7, 2022. It is now read-only.
Add support for specifying service name in config#602
Merged
pjanotti merged 3 commits intocensus-instrumentation:masterfrom Jul 20, 2019
mads-hartmann:add-service-name-config-to-datadog-exporter
Merged
Add support for specifying service name in config#602pjanotti merged 3 commits intocensus-instrumentation:masterfrom mads-hartmann:add-service-name-config-to-datadog-exporter
pjanotti merged 3 commits intocensus-instrumentation:masterfrom
mads-hartmann:add-service-name-config-to-datadog-exporter
Conversation
The datadog exporter will currently drop the service name which is specified in the spans. See #198 for more information. This aligns the datadog exporter with jaeger, wavefront, and zipkin. They already have this option. A better solution would be to add support for multiple services, as many of the other exporters have, but that is a bit over the level of contribution I can do at the moment.
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 68.87% 68.86% -0.02%
==========================================
Files 92 92
Lines 6066 6067 +1
==========================================
Hits 4178 4178
- Misses 1669 1670 +1
Partials 219 219
Continue to review full report at Codecov.
|
pjanotti
approved these changes
Jul 15, 2019
pjanotti
left a comment
There was a problem hiding this comment.
Sorry for the delay @mads-hartmann. LGTM.
Contributor
Author
|
@pjanotti no problem 😊 thanks for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datadog exporter will currently drop the service name which is specified in the spans. See #198 for more information.
This aligns the datadog exporter with jaeger, wavefront, and zipkin. They already have this option.
A better solution would be to add support for multiple services, as many of the other exporters have, but that is a bit over the level of contribution I can do at the moment.
I've tested this against a live datadog setup and the service name is correctly propagated and displayed in their UI.
If you are okay with this contribution I will update the docs accordingly 😊