This repository was archived by the owner on Nov 7, 2022. It is now read-only.
receiver/prometheus: migrate code in here#481
Closed
odeke-em wants to merge 1 commit intocensus-instrumentation:masterfrom
orijtech:bring-in-prometheus-receiver
Closed
receiver/prometheus: migrate code in here#481odeke-em wants to merge 1 commit intocensus-instrumentation:masterfrom orijtech:bring-in-prometheus-receiver
odeke-em wants to merge 1 commit intocensus-instrumentation:masterfrom
orijtech:bring-in-prometheus-receiver
Conversation
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 57.02% 57.49% +0.46%
==========================================
Files 69 68 -1
Lines 4247 4759 +512
==========================================
+ Hits 2422 2736 +314
- Misses 1666 1844 +178
- Partials 159 179 +20
Continue to review full report at Codecov.
|
songy23
reviewed
Mar 7, 2019
Contributor
songy23
left a comment
There was a problem hiding this comment.
Suggestion: this PR is too huge to review, consider putting the parsing logic in a util file and have a separate PR for it first.
Hand over prometheus exporter code that I had parked in https://github.com/orijtech/promreceiver That code was written for OpenCensus Authors, and was just waiting for a final destination. This change finishes that. Fixes #480
|
Hi @odeke-em, I'm closing this PR since it is stale for some time and iirc was superseded by other (later closed), let's know if that is not correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hand over prometheus exporter code that I had
parked in https://github.com/orijtech/promreceiver
That code was written for OpenCensus Authors, and was just
waiting for a final destination. This change finishes that.
Fixes #480