Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Fix stackdriver tests#921

Merged
c24t merged 2 commits intocensus-instrumentation:masterfrom
aabmass:fix-sd-tests-905
Jun 24, 2020
Merged

Fix stackdriver tests#921
c24t merged 2 commits intocensus-instrumentation:masterfrom
aabmass:fix-sd-tests-905

Conversation

@aabmass
Copy link
Copy Markdown
Member

@aabmass aabmass commented Jun 24, 2020

Fixes #905. Reset the stackdriver tests to commit fce9d22. The google-auth package upgraded the version of rsa, but rsa 4.1 drops python 2 and 3.4 support. Solution is to pin the rsa package version for unsupported python versions.

Although google-auth has dropped 2.7, it still supports 3.4 so I opened an issue with them googleapis/google-auth-library-python#548

@aabmass aabmass force-pushed the fix-sd-tests-905 branch from 15da7f5 to 0047bcd Compare June 24, 2020 18:44
@aabmass aabmass marked this pull request as ready for review June 24, 2020 18:56
@aabmass aabmass requested review from a team, c24t, hectorhdzg, lzchen, reyang and songy23 as code owners June 24, 2020 18:56
@aabmass aabmass force-pushed the fix-sd-tests-905 branch from 0047bcd to f9ae95c Compare June 24, 2020 19:21
Copy link
Copy Markdown
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@c24t c24t merged commit 05b1b99 into census-instrumentation:master Jun 24, 2020
@aabmass aabmass deleted the fix-sd-tests-905 branch June 24, 2020 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stackdriver tests failing and blocking build

4 participants