This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Remove coverage temporarily to unblock CI#842
Merged
lzchen merged 3 commits intocensus-instrumentation:masterfrom Jan 15, 2020
Merged
Remove coverage temporarily to unblock CI#842lzchen merged 3 commits intocensus-instrumentation:masterfrom
lzchen merged 3 commits intocensus-instrumentation:masterfrom
Conversation
Member
|
For more context: coverage is passing locally, but failing on CircleCI because of a missing The base images that CircleCI provides for python projects (circleci/python) work as expected, but each image only includes a single version of python. Since we test multiple python versions on the same image now, we'd have to make significant changes to our nox and CircleCI config to use these images instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests are failing for CircleCI due to failed import of
sqlite3which is a dependency forcoverage.All Python environments fail except for
3.4.@c24t did some investigation and apparently using a different CircleCI image did not make the error show up, but this does not solve the issue. Removing coverage temporarily to unblock other PRs.