This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add optional custom properties to logging messages.#822
Merged
lzchen merged 1 commit intocensus-instrumentation:masterfrom Nov 26, 2019
Merged
Conversation
lzchen
reviewed
Nov 21, 2019
lzchen
reviewed
Nov 21, 2019
lzchen
approved these changes
Nov 22, 2019
Contributor
lzchen
left a comment
There was a problem hiding this comment.
Looks good! Just a few comments.
82a59ad to
f6ebee7
Compare
Include a dictionary with custom properties with the logging message whenever they are present. These properties could be later searched from the Log Analytics workspace from the "traces" table.
f6ebee7 to
2a75efe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to allow users to track additional information to logging actions by simply adding to the default properties, any additional metadata passed by the user in the form of a dictionary.
The usage of this would look like this:
Once this data is uploaded to App Insights, you can search in the
tracestable by keys included in thecustomDimensionscolumn like this:This is a good option instead of using Custom Events which is not currently supported in Open Census.