Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Create README.rst for the Datadog trace exporter#799

Merged
lzchen merged 4 commits intocensus-instrumentation:masterfrom
nbutton23:dd-exporter-docs
Oct 14, 2019
Merged

Create README.rst for the Datadog trace exporter#799
lzchen merged 4 commits intocensus-instrumentation:masterfrom
nbutton23:dd-exporter-docs

Conversation

@nbutton23
Copy link
Copy Markdown
Contributor

@nbutton23 nbutton23 commented Oct 7, 2019

Created a README.rst for the Datadog trace Exporter based on the Azure Monitor exporter

@nbutton23 nbutton23 requested review from a team, c24t, reyang and songy23 as code owners October 7, 2019 14:47
@nbutton23 nbutton23 mentioned this pull request Oct 7, 2019
Merged
reyang
reyang reviewed Oct 7, 2019
View reviewed changes
contrib/opencensus-ext-datadog/CHANGELOG.md Outdated

## Unreleased
- Initial version.
## 0.1.0
Copy link
Copy Markdown
Contributor

@reyang reyang Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one hasn't been released to PyPI (e.g. https://pypi.org/project/opencensus/) yet. We should leave it as Unreleased.

reyang
reyang suggested changes Oct 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert changelog. Other parts look great!

@googlebot
Copy link
Copy Markdown

googlebot commented Oct 14, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@nbutton23
Copy link
Copy Markdown
Contributor Author

nbutton23 commented Oct 14, 2019

@googlebot I fixed it.

@googlebot
Copy link
Copy Markdown

googlebot commented Oct 14, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lzchen lzchen merged commit d7d31eb into census-instrumentation:master Oct 14, 2019
@nbutton23 nbutton23 deleted the dd-exporter-docs branch October 14, 2019 16:27
@nbutton23
Copy link
Copy Markdown
Contributor Author

nbutton23 commented Nov 11, 2019

@reyang What is the process for releasing this?

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Nov 14, 2019

@nbutton23
I can do a minor release for opencensus-ext-datadog. Are you waiting on the package to be released before uploading to PyPI or is it already on PyPi?

@nbutton23
Copy link
Copy Markdown
Contributor Author

nbutton23 commented Nov 15, 2019 •
edited
Loading

@lzchen
I am new to Python so don't know the release and packaging process. So I have never push anything to PyPI

@lzchen lzchen mentioned this pull request Nov 18, 2019
Merged
@RenaultAI RenaultAI mentioned this pull request Jan 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@c24t c24t Awaiting requested review from c24t

@songy23 songy23 Awaiting requested review from songy23

2 more reviewers

@lzchen lzchen lzchen approved these changes

@reyang reyang reyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nbutton23 @googlebot @lzchen @reyang