This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Use Django 2.0 DB instrumentation#775
Merged
reyang merged 2 commits intocensus-instrumentation:masterfrom Aug 30, 2019
tpyo:add-django2-db-instrumentation
Merged
Use Django 2.0 DB instrumentation#775reyang merged 2 commits intocensus-instrumentation:masterfrom tpyo:add-django2-db-instrumentation
reyang merged 2 commits intocensus-instrumentation:masterfrom
tpyo:add-django2-db-instrumentation
Conversation
|
Awesome work, @tpyo. Will hopefully test this a bit later this week. |
reyang
reviewed
Aug 27, 2019
contrib/opencensus-ext-django/opencensus/ext/django/middleware.py
Outdated
Show resolved
Hide resolved
reyang
reviewed
Aug 27, 2019
contrib/opencensus-ext-django/opencensus/ext/django/middleware.py
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Aug 27, 2019
Contributor
reyang
left a comment
There was a problem hiding this comment.
Looks good overall, I have some comments regarding the attribute/status schema.
Contributor
|
Please rebase and then we're ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the work @zoidbergwill started in #358
Have made a couple of small fixes to the original code: