This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Standard Metrics - Incoming Requests Execution Time#773
Merged
lzchen merged 8 commits intocensus-instrumentation:masterfrom Aug 27, 2019
Merged
Standard Metrics - Incoming Requests Execution Time#773lzchen merged 8 commits intocensus-instrumentation:masterfrom
lzchen merged 8 commits intocensus-instrumentation:masterfrom
Conversation
reyang
reviewed
Aug 24, 2019
...opencensus-ext-azure/opencensus/ext/azure/metrics_exporter/standard_metrics/http_requests.py
Outdated
Show resolved
Hide resolved
reyang
reviewed
Aug 24, 2019
...opencensus-ext-azure/opencensus/ext/azure/metrics_exporter/standard_metrics/http_requests.py
Outdated
Show resolved
Hide resolved
reyang
reviewed
Aug 24, 2019
...opencensus-ext-azure/opencensus/ext/azure/metrics_exporter/standard_metrics/http_requests.py
Show resolved
Hide resolved
reyang
reviewed
Aug 24, 2019
...opencensus-ext-azure/opencensus/ext/azure/metrics_exporter/standard_metrics/http_requests.py
Show resolved
Hide resolved
reyang
reviewed
Aug 24, 2019
...opencensus-ext-azure/opencensus/ext/azure/metrics_exporter/standard_metrics/http_requests.py
Show resolved
Hide resolved
reyang
suggested changes
Aug 24, 2019
Contributor
reyang
left a comment
There was a problem hiding this comment.
Need to make sure there is no race condition.
reyang
reviewed
Aug 27, 2019
...encensus-ext-azure/opencensus/ext/azure/metrics_exporter/standard_metrics/http_dependency.py
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Aug 27, 2019
Contributor
reyang
left a comment
There was a problem hiding this comment.
Looks good in general, I've left some comments regarding the definitions of "average execution time".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of [#695]. Standard metric for incoming requests Average Execution Time in milliseconds. Incoming requests are under "http_requests".
Track incoming requests to an HTTPServer on the application. Currently, incoming requests are shown "performanceCounters" table in Application Insights.
This is the last standard metric as part of the effort to achieve feature parity with Application Insights SDK in other languages.