Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Stats: Remove min and max from Distribution.#501

Merged
songy23 merged 4 commits intocensus-instrumentation:masterfrom
songy23:distribution
Feb 12, 2019
Merged

Stats: Remove min and max from Distribution.#501
songy23 merged 4 commits intocensus-instrumentation:masterfrom
songy23:distribution

Conversation

@songy23
Copy link
Copy Markdown
Contributor

@songy23 songy23 commented Feb 12, 2019

Fixes #411.

min and max have been removed from Distribution in all other languages.

@@ -1,4 +1,5 @@
# Copyright 2018, OpenCensus Authors
# Copyright 2018, OpenCensus Authors
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, seems to be a bad copy-and-paste.

Copy link
Copy Markdown
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one typo.

@songy23 songy23 merged commit 6c472df into census-instrumentation:master Feb 12, 2019
@songy23 songy23 deleted the distribution branch February 12, 2019 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants