This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Run integration tests with different permutations of dependencies.#202
Open
brianquinlan wants to merge 2 commits intocensus-instrumentation:masterfrom
brianquinlan:master
Open
Run integration tests with different permutations of dependencies.#202brianquinlan wants to merge 2 commits intocensus-instrumentation:masterfrom brianquinlan:master
brianquinlan wants to merge 2 commits intocensus-instrumentation:masterfrom
brianquinlan:master
Conversation
liyanhui1228
reviewed
Jun 6, 2018
| session.interpreter = 'python{}'.format(py) | ||
|
|
||
| # Install all test dependencies, then install this package in-place. | ||
| session.install('google-cloud-trace') |
Contributor
There was a problem hiding this comment.
Are we going to run unit tests against the latest version of google-cloud-trace? While this can make sure our library works well with the latest release version of it, but it would be confusing whether the tests failed because of the version incompatibility issue or the tested code itself.
I would suggest we pin the version used for tests and add tooling for ensuring we work well with the latest release when the tools is built.
Contributor
Author
There was a problem hiding this comment.
Should we pin the version or test with the versions matching setup.py i.e.
google-cloud-trace=0.17.0, google-cloud-trace<0.20
google-api-core = 0.1.1, google-api-color < 2.0.0
?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good idea or not.