Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Add tracestate field to the Span proto.#74

Merged
bogdandrutu merged 1 commit intocensus-instrumentation:masterfrom
bogdandrutu:tracestate
Aug 21, 2018
Merged

Add tracestate field to the Span proto.#74
bogdandrutu merged 1 commit intocensus-instrumentation:masterfrom
bogdandrutu:tracestate

Conversation

@bogdandrutu
Copy link
Copy Markdown
Contributor

No description provided.

// returns, etc.
//
// See the https://github.com/w3c/distributed-tracing for more details about this field.
map<string, string> tracestate = 15;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider ordering the fields by its field number. Same for kind.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is map ordered in proto? Not that important for storing as for propagation, but nevertheless for consistency it may be better to have a list

@bogdandrutu
Copy link
Copy Markdown
Contributor Author

@lmolkova I would like you or @SergeyKanzhelev to look into this and approve it.

@bogdandrutu bogdandrutu merged commit 5524008 into census-instrumentation:master Aug 21, 2018
@bogdandrutu bogdandrutu deleted the tracestate branch August 21, 2018 20:20
@codefromthecrypt
Copy link
Copy Markdown
Contributor

codefromthecrypt commented Aug 22, 2018 via email

@codefromthecrypt
Copy link
Copy Markdown
Contributor

codefromthecrypt commented Aug 23, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants