This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add grpc-gateway for metrics service.#205
Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom Jul 18, 2019
Merged
Add grpc-gateway for metrics service.#205songy23 merged 2 commits intocensus-instrumentation:masterfrom
songy23 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
draffensperger
approved these changes
Jul 17, 2019
Contributor
draffensperger
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Contributor
Author
|
Travis CI failure is not related to this change: ERROR: /home/travis/.cache/bazel/_bazel_travis/6ad1f67d610d9e7d574100e0c95311d1/external/grpc_java/java_grpc_library.bzl:40:17: Traceback (most recent call last):
File "/home/travis/.cache/bazel/_bazel_travis/6ad1f67d610d9e7d574100e0c95311d1/external/grpc_java/java_grpc_library.bzl", line 38
rule(attrs = {"srcs": attr.label_list...")}, <2 more arguments>)
File "/home/travis/.cache/bazel/_bazel_travis/6ad1f67d610d9e7d574100e0c95311d1/external/grpc_java/java_grpc_library.bzl", line 40, in rule
attr.label_list(mandatory = True, non_empty = True, ..."])
'non_empty' is no longer supported. use allow_empty instead. You can use --incompatible_disable_deprecated_attr_params=false to temporarily disable this check.Will fix in a separate PR. |
bogdandrutu
approved these changes
Jul 18, 2019
Contributor
|
Please rebase. |
2628c9b to
da3bfd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204.