This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Start dropping spans when the span exporter thread holds more than 10K spans references.#1893
Merged
bogdandrutu merged 5 commits intocensus-instrumentation:masterfrom May 13, 2019
Merged
Conversation
…K spans references.
songy23
reviewed
May 13, 2019
impl_core/src/main/java/io/opencensus/implcore/trace/export/SpanExporterImpl.java
Outdated
Show resolved
Hide resolved
impl_core/src/main/java/io/opencensus/implcore/trace/export/SpanExporterImpl.java
Outdated
Show resolved
Hide resolved
dinooliva
reviewed
May 13, 2019
impl_core/src/main/java/io/opencensus/implcore/trace/export/SpanExporterImpl.java
Outdated
Show resolved
Hide resolved
| public final class SpanExporterImpl extends SpanExporter { | ||
| private static final Logger logger = Logger.getLogger(ExportComponent.class.getName()); | ||
| private static final DerivedLongCumulative droppedSpans = | ||
| Metrics.getMetricRegistry() |
Contributor
There was a problem hiding this comment.
Tracing impl now depends on Metrics - that seems fine - I prefer not to have cyclic dependencies but, iiuc, this doesn't introduce them. Interesting issue, tho - if we split the artifacts for tracing and metrics, this won't work.
Contributor
Author
There was a problem hiding this comment.
It depends only on the API artifact not the impl artifact.
Contributor
There was a problem hiding this comment.
My second point was that a service that links in a tracing impl but not a metrics impl will get unexpected results - not an issue with the current way we package artifacts but could be a problem if we ever decide to split the implementation artifacts.
rghetia
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1767