This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Remove min/max from Distribution.#1542
Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom Nov 2, 2018
Merged
Remove min/max from Distribution.#1542songy23 merged 2 commits intocensus-instrumentation:masterfrom
songy23 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
============================================
- Coverage 82.93% 82.89% -0.05%
Complexity 1658 1658
============================================
Files 251 251
Lines 7719 7711 -8
Branches 754 748 -6
============================================
- Hits 6402 6392 -10
- Misses 1097 1099 +2
Partials 220 220
Continue to review full report at Codecov.
|
songy23
approved these changes
Nov 2, 2018
Contributor
songy23
left a comment
There was a problem hiding this comment.
Please add this to CHANGELOG.
mayurkale22
approved these changes
Nov 2, 2018
mayurkale22
reviewed
Nov 2, 2018
| - The histogram bucket boundaries (`BucketBoundaries`) and values (`Count` and `Sum`) are no longer | ||
| supported for negative values. The Record API drops the negative `value` and logs the warning. | ||
| This could be a breaking change if you are recording negative value for any `measure`. | ||
| - Remove support for min/max in the stats Distribution to make it compatible with Metrics. |
Member
There was a problem hiding this comment.
Can we also consider to change mean -> sum in stats Distribution to make it compatible with Metrics Distribution. ?
Contributor
There was a problem hiding this comment.
Please file an issue for that. It should be in a separate PR.
This was referenced Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.