Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Consider changing DisruptorEventQueue.enqueue() to avoid possibility of blocking  #1809

Open
Open
Consider changing DisruptorEventQueue.enqueue() to avoid possibility of blocking #1809
Labels
P1discussionenhancement
@jmullins

Description

@jmullins
jmullins
opened on Mar 22, 2019

Does it make sense to change DisruptorEventQueue.enqueue() to use RingBuffer.tryNext() instead of RingBuffer.next() to avoid possibly blocking in the case the producers overrun the consumer due to load or a future bug in the consumer?

In all of our use-cases our preference would be to drop the metrics rather than block.

opencensus-java/impl/src/main/java/io/opencensus/impl/internal/DisruptorEventQueue.java

Lines 130 to 142 in aa8ee6a

DisruptorEnqueuer enqueuer =
new DisruptorEnqueuer() {
@Override
public void enqueue(Entry entry) {
long sequence = ringBuffer.next();
try {
DisruptorEvent event = ringBuffer.get(sequence);
event.setEntry(entry);
} finally {
ringBuffer.publish(sequence);
}
}
};

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1discussionenhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions