This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Replace "x/net/context" import with "context"#983
Closed
rakyll wants to merge 1 commit intocensus-instrumentation:masterfrom
Closed
Replace "x/net/context" import with "context"#983rakyll wants to merge 1 commit intocensus-instrumentation:masterfrom
rakyll wants to merge 1 commit intocensus-instrumentation:masterfrom
Conversation
We also need to pin to a gRPC version that includes grpc/grpc-go@04ea820.
Contributor
Author
|
@jadekler We need a new gRPC version to merge this PR. |
Contributor
bogdandrutu
approved these changes
Nov 28, 2018
Contributor
|
@rakyll is this safe to merge now? |
Contributor
|
@rakyll have you had the chance to talk to gRPC devs about this? |
Contributor
|
Speaking for myself, I believe this is safe. We have done likewise in several Go libraries and the last few gRPC versions have migrated to not using x/net/context. |
Contributor
|
@rakyll can we get this in the next couple of days? |
Contributor
|
Friendly ping. Should we rebase and merge this PR? |
Contributor
Author
|
Can someone else work on a PR from scratch instead? Closing this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also need to pin to a gRPC version that includes
grpc/grpc-go@04ea820.