This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Passing capacity to make() in place of length. #1276
Merged
punya merged 2 commits intocensus-instrumentation:masterfrom Mar 31, 2022
fayfaychan:makefix
Merged
Passing capacity to make() in place of length. #1276punya merged 2 commits intocensus-instrumentation:masterfrom fayfaychan:makefix
punya merged 2 commits intocensus-instrumentation:masterfrom
fayfaychan:makefix
Conversation
… length and not capacity.
punya
approved these changes
Mar 31, 2022
punya
suggested changes
Mar 31, 2022
Contributor
punya
left a comment
There was a problem hiding this comment.
Sorry, I didn't notice that this tried to change maps in addition to slices. Please fix the compilation errors.
punya
approved these changes
Mar 31, 2022
|
I'm fairly confident this improves the memory footprint/fixes a memory leak happening to any consuming package relying on opencensus-go for generating traces. Great job @fayfaychan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second argument is length and not capacity.