Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

fix memory leak cause by the spanStore.(census-instrumentation/opence…#1246

Merged
dashpole merged 2 commits intocensus-instrumentation:masterfrom
red7x:master
Dec 16, 2020
Merged

fix memory leak cause by the spanStore.(census-instrumentation/opence…#1246
dashpole merged 2 commits intocensus-instrumentation:masterfrom
red7x:master

Conversation

@red7x
Copy link
Copy Markdown
Contributor

@red7x red7x commented Dec 15, 2020

…nsus-go#1245)

  • when enable the spanStore and call startSpan and End in a loop, it cause memory leak. Found that it delete the wrong ptr in active set of spanStore in span's End() Method

@red7x red7x requested review from a team and rghetia as code owners December 15, 2020 04:25
@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 15, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 15, 2020
@red7x
Copy link
Copy Markdown
Contributor Author

red7x commented Dec 15, 2020

@googlebot I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 15, 2020
@dashpole
Copy link
Copy Markdown
Collaborator

Ah, I think I broke this when I added the SpanInterface. I think we can fix this by changing the spanStore methods to use the SpanInterface instead of the *Span

@dashpole dashpole closed this Dec 15, 2020
@dashpole dashpole reopened this Dec 15, 2020
@red7x
Copy link
Copy Markdown
Contributor Author

red7x commented Dec 16, 2020

sounds reasonable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants