This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Revert "Allow replacing trace SDK (#1234)"#1235
Merged
rghetia merged 1 commit intocensus-instrumentation:masterfrom Oct 23, 2020
tbpg:revert
Merged
Revert "Allow replacing trace SDK (#1234)"#1235rghetia merged 1 commit intocensus-instrumentation:masterfrom tbpg:revert
rghetia merged 1 commit intocensus-instrumentation:masterfrom
tbpg:revert
Conversation
This reverts commit fc3822b.
Contributor
Author
rghetia
approved these changes
Oct 23, 2020
|
@tbpg It seems that you're using the HEAD revision for some reason? The breaking change wasn't released yet AFAICT. @dashpole if we can come up with a backward compatible solution that would be preferred over the reverted change. |
Contributor
Author
|
In GOPATH mode, you need some extra dependency/vendor management to depend on a specific version. We don't have that at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fc3822b.
This is causing a break in Google Cloud Functions, which depends on master when running in GOPATH mode.
See GoogleCloudPlatform/functions-framework-go#56.
Here is the error: