Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Initialize View Start Time During View Registration#1215

Merged
nilebox merged 3 commits intocensus-instrumentation:masterfrom
ian-mi:initialize-view-start-time
Jun 17, 2020
Merged

Initialize View Start Time During View Registration#1215
nilebox merged 3 commits intocensus-instrumentation:masterfrom
ian-mi:initialize-view-start-time

Conversation

@ian-mi
Copy link
Copy Markdown
Contributor

@ian-mi ian-mi commented Jun 17, 2020

@ian-mi ian-mi requested review from a team, rakyll and rghetia as code owners June 17, 2020 00:04
@ian-mi
Copy link
Copy Markdown
Contributor Author

ian-mi commented Jun 17, 2020

@nilebox

Copy link
Copy Markdown

@nilebox nilebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one remaining cleanup.

w.mu.Lock()
defer w.mu.Unlock()
delete(w.views, v.view.Name)
delete(w.startTimes, v)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ian-mi ian-mi requested review from nilebox and removed request for a team June 17, 2020 03:12
@nilebox nilebox merged commit 5fa069b into census-instrumentation:master Jun 17, 2020
@ian-mi ian-mi deleted the initialize-view-start-time branch June 17, 2020 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The start time must be before the end time for the non-gauge metric

3 participants