This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Safely reject invalid-length span and trace ids#1206
Merged
rghetia merged 1 commit intocensus-instrumentation:masterfrom Apr 2, 2020
Merged
Safely reject invalid-length span and trace ids#1206rghetia merged 1 commit intocensus-instrumentation:masterfrom
rghetia merged 1 commit intocensus-instrumentation:masterfrom
Conversation
rghetia
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1205
Current behaviour is to panic on span/trace IDs with valid hex encoding which exceed expected lengths.
This PR causes these IDs to be rejected as for any other invalid encoding.