This repository was archived by the owner on Jul 31, 2023. It is now read-only.
exclude zero bucket from aggregation_data#1183
Merged
rghetia merged 3 commits intocensus-instrumentation:masterfrom Nov 9, 2019
Merged
exclude zero bucket from aggregation_data#1183rghetia merged 3 commits intocensus-instrumentation:masterfrom
rghetia merged 3 commits intocensus-instrumentation:masterfrom
Conversation
Contributor
Author
|
@songy23 @dinooliva can either one of you please look at this? Thanks. |
songy23
approved these changes
Nov 8, 2019
Contributor
songy23
left a comment
There was a problem hiding this comment.
Minor nit, otherwise LGTM.
stats/view/view_to_metric_test.go
Outdated
| m := stats.Int64("OutOfOrderWithZeroBuckets", "", "") | ||
| v := &View{ | ||
| Measure: m, | ||
| Aggregation: Distribution(10, 0, 2), |
Contributor
There was a problem hiding this comment.
Can you add a test with bucket bounds like [0, 5, 10]?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1169