This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Fix bug in ocgrpc client logging#1161
Merged
rghetia merged 1 commit intocensus-instrumentation:masterfrom Sep 3, 2019
bvwells:logBug
Merged
Fix bug in ocgrpc client logging#1161rghetia merged 1 commit intocensus-instrumentation:masterfrom bvwells:logBug
rghetia merged 1 commit intocensus-instrumentation:masterfrom
bvwells:logBug
Conversation
rghetia
approved these changes
Sep 3, 2019
Contributor
Author
|
Thanks for the merge @rghetia! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug in ocgrpc client logging. Info is nil in the logging branch so info.FullMethodName will cause a crash.