This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Map 422 Unprocessable Entity to INVALID_ARGUMENT#1149
Merged
songy23 merged 1 commit intocensus-instrumentation:masterfrom Jul 2, 2019
Merged
Map 422 Unprocessable Entity to INVALID_ARGUMENT#1149songy23 merged 1 commit intocensus-instrumentation:masterfrom
songy23 merged 1 commit intocensus-instrumentation:masterfrom
Conversation
rghetia
approved these changes
Jul 2, 2019
songy23
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL prefers to use
422 Unprocessable Entitywhen malformed queries are made to a server.We're using this library to collect and send traces to our APM provider and their OC exporter has a mapping of TraceStatus -> client/server errors. Currently 422 gets lumped into
UNKNOWN, which is tracked as a server error.This change maps 422 to
INVALID_ARGUMENT, so garbage posted on our graphql endpoint doesn't wake us up! :)